Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the tree cloner also clone Member(TypeNameExpression) to ensure the result is a DAG #4539

Merged
merged 3 commits into from
Apr 6, 2024
Merged

Make the tree cloner also clone Member(TypeNameExpression) to ensure the result is a DAG #4539

merged 3 commits into from
Apr 6, 2024

Conversation

mihaibudiu
Copy link
Contributor

No description provided.

@mihaibudiu
Copy link
Contributor Author

Fixes #4500

@mihaibudiu
clang-format
43072e1 
Signed-off-by: Mihai Budiu <[email protected]>
@mihaibudiu mihaibudiu requested a review from fruffy March 15, 2024 18:39
@fruffy fruffy added the core Topics concerning the core segments of the compiler (frontend, midend, parser) label Mar 16, 2024
@fruffy fruffy requested a review from kfcripps March 16, 2024 17:56
kfcripps
kfcripps reviewed Mar 18, 2024
View reviewed changes
Copy link
Contributor

@kfcripps kfcripps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now, ClonePathExpressions does not clone only PathExpressions. Should we change its name (and update the comment above the class definition) to reflect this?

@mihaibudiu
Copy link
Contributor Author

I will let other people do the desired cleanups.

@kfcripps
Copy link
Contributor

Done. @fruffy I don't want to approve my own changes so please approve if the second commit looks good to you. The first commit LGTM. Thank you @mihaibudiu for fixing this.

@kfcripps kfcripps mentioned this pull request Mar 19, 2024
Closed
@fruffy
Copy link
Collaborator

fruffy commented Mar 19, 2024

ArrayIndices may also be relevant here.

@fruffy fruffy added this pull request to the merge queue Apr 6, 2024
Merged via the queue into p4lang:main with commit cad37c1 Apr 6, 2024
17 checks passed
This was referenced Jul 12, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfcripps kfcripps kfcripps left review comments

@fruffy fruffy fruffy approved these changes

Assignees
No one assigned
Labels
core Topics concerning the core segments of the compiler (frontend, midend, parser)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihaibudiu @kfcripps @fruffy